[Mesa-dev] [PATCH 03/15] i965/fs: Add support for translating ir_triop_fma into MAD.

[Paul Berry]

On 26 August 2013 22:00, Matt Turner <mattst88 at gmail.com> wrote:

> Thanks Paul.
>
> I've placed this patch as 2.5/15 in the series.
>
> i965/fs: Assert that ir_expressions are usable by 3-src instructions
>
> MAD will be generated directly from ir_triop_fma, so this assertion
> checks that all ir_expressions are usable.
>

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


> ---
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> index 27887d6..a02d92d 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> @@ -336,6 +336,7 @@ fs_visitor::visit(ir_expression *ir)
>          ir->operands[operand]->print();
>           printf("\n");
>        }
> +      assert(this->result.is_valid_3src());
>

I spent a while trying to think of a commet that could go above the assert,
to help someone who stumbles across it in the future and wonders why the
assertion is here rather than in the switch statement below, but I couldn't
really think of anything :(


>        op[operand] = this->result;
>
>        /* Matrix expression operands should have been broken down to vector
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130827/496abbd2/attachment.html>