[Mesa-dev] [PATCH 4/6] i965: Clarify that we only check one prim's type for cut index support.

Eric Anholt eric at anholt.net
Fri Aug 30 10:36:43 PDT 2013


Kenneth Graunke <kenneth at whitecape.org> writes:

> can_cut_index_handle_prims() was passed an array of _mesa_prim objects
> and a count, and runs a loop for that many iterations.  However, it
> treats the array like a pointer, repeatedly checking the first element.
>
> This is wasteful and bizarre.
>
> The VBO module will never call us with multiple primitives of different
> topologies, so it's actually reasonable to just check the first element.

I'm pretty sure it will.  I don't see anything in vbo_exec_Begin()
making sure the new primitive is the same type as the last.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130830/c6830ee1/attachment.pgp>


More information about the mesa-dev mailing list