[Mesa-dev] [PATCH 08/11] mesa: Implement the GL entry points defined by ARB_shader_image_load_store.

[Francisco Jerez]

Paul Berry <stereotype441 at gmail.com> writes:

> On 7 December 2013 17:11, Francisco Jerez <currojerez at riseup.net> wrote:
>
>> Paul Berry <stereotype441 at gmail.com> writes:
>[...]
>
> Wow, that explains why I never managed to pick up the convention by
> osmosis.  Thanks for explaining.
>
> BTW, after reading through format_pack.c, I found some exceptions to what
> you said above.  The following formats are always packed by format_pack.c
> in reverse memory order, regardless of endianness:
>
> - MESA_FORMAT_RGB888
> - MESA_FORMAT_BGR888
> - MESA_FORMAT_SRGB8
> - MESA_FORMAT_XBGR16161616_UNORM
> - MESA_FORMAT_XBGR16161616_SNORM
> - MESA_FORMAT_XBGR16161616_FLOAT
> - MESA_FORMAT_XBGR32323232_FLOAT
>
> Which means they get packed correctly on little-endian systems but
> backwards on big-endian systems.  This seems like it's a bug in
> format_pack.c, so it's not relevant to your patch :)

I suspect that format_pack.c is correct and those formats were meant to
be packed with a fixed memory ordering, it's just the naming that seems
to be inconsistent.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131210/905bb0cb/attachment.pgp>