[Mesa-dev] [PATCH 01/11] glapi: Update dispatch XML files for ARB_shader_image_load_store.

[Paul Berry]

On 24 November 2013 21:00, Francisco Jerez <currojerez at riseup.net> wrote:

> +<enum name="VERTEX_ATTRIB_ARRAY_BARRIER_BIT" value="0x00000001"/>
> +<enum name="ELEMENT_ARRAY_BARRIER_BIT" value="0x00000002"/>
> +<enum name="UNIFORM_BARRIER_BIT" value="0x00000004"/>
> +<enum name="TEXTURE_FETCH_BARRIER_BIT" value="0x00000008"/>
> +<enum name="SHADER_IMAGE_ACCESS_BARRIER_BIT" value="0x00000020"/>
> +<enum name="COMMAND_BARRIER_BIT" value="0x00000040"/>
> +<enum name="PIXEL_BUFFER_BARRIER_BIT" value="0x00000080"/>
> +<enum name="TEXTURE_UPDATE_BARRIER_BIT" value="0x00000100"/>
> +<enum name="BUFFER_UPDATE_BARRIER_BIT" value="0x00000200"/>
> +<enum name="FRAMEBUFFER_BARRIER_BIT" value="0x00000400"/>
> +<enum name="TRANSFORM_FEEDBACK_BARRIER_BIT" value="0x00000800"/>
> +<enum name="ATOMIC_COUNTER_BARRIER_BIT" value="0x00001000"/>
> +<enum name="ALL_BARRIER_BITS" value="0xFFFFFFFF"/>
> +<enum name="MAX_IMAGE_UNITS" value="0x8F38"/>
> +<enum name="MAX_COMBINED_IMAGE_UNITS_AND_FRAGMENT_OUTPUTS"
> value="0x8F39"/>
> +<enum name="IMAGE_BINDING_NAME" value="0x8F3A"/>
> +<enum name="IMAGE_BINDING_LEVEL" value="0x8F3B"/>
> +<enum name="IMAGE_BINDING_LAYERED" value="0x8F3C"/>
> +<enum name="IMAGE_BINDING_LAYERED_EXT" value="0x8F3C"/>
>

I'm surprised to see IMAGE_BINDING_LAYERED_EXT here instead of
IMAGE_BINDING_LAYER.  I assume this was just a typographical error?

Change this line to:

<enum name="IMAGE_BINDING_LAYER" value="0x8F3D"/>

(note: the value also needs to change), and this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


> +<enum name="IMAGE_BINDING_ACCESS" value="0x8F3E"/>
> +<enum name="IMAGE_1D" value="0x904C"/>
> +<enum name="IMAGE_2D" value="0x904D"/>
> +<enum name="IMAGE_3D" value="0x904E"/>
> +<enum name="IMAGE_2D_RECT" value="0x904F"/>
> +<enum name="IMAGE_CUBE" value="0x9050"/>
> +<enum name="IMAGE_BUFFER" value="0x9051"/>
> +<enum name="IMAGE_1D_ARRAY" value="0x9052"/>
> +<enum name="IMAGE_2D_ARRAY" value="0x9053"/>
> +<enum name="IMAGE_CUBE_MAP_ARRAY" value="0x9054"/>
> +<enum name="IMAGE_2D_MULTISAMPLE" value="0x9055"/>
> +<enum name="IMAGE_2D_MULTISAMPLE_ARRAY" value="0x9056"/>
> +<enum name="INT_IMAGE_1D" value="0x9057"/>
> +<enum name="INT_IMAGE_2D" value="0x9058"/>
> +<enum name="INT_IMAGE_3D" value="0x9059"/>
> +<enum name="INT_IMAGE_2D_RECT" value="0x905A"/>
> +<enum name="INT_IMAGE_CUBE" value="0x905B"/>
> +<enum name="INT_IMAGE_BUFFER" value="0x905C"/>
> +<enum name="INT_IMAGE_1D_ARRAY" value="0x905D"/>
> +<enum name="INT_IMAGE_2D_ARRAY" value="0x905E"/>
> +<enum name="INT_IMAGE_CUBE_MAP_ARRAY" value="0x905F"/>
> +<enum name="INT_IMAGE_2D_MULTISAMPLE" value="0x9060"/>
> +<enum name="INT_IMAGE_2D_MULTISAMPLE_ARRAY" value="0x9061"/>
> +<enum name="UNSIGNED_INT_IMAGE_1D" value="0x9062"/>
> +<enum name="UNSIGNED_INT_IMAGE_2D" value="0x9063"/>
> +<enum name="UNSIGNED_INT_IMAGE_3D" value="0x9064"/>
> +<enum name="UNSIGNED_INT_IMAGE_2D_RECT" value="0x9065"/>
> +<enum name="UNSIGNED_INT_IMAGE_CUBE" value="0x9066"/>
> +<enum name="UNSIGNED_INT_IMAGE_BUFFER" value="0x9067"/>
> +<enum name="UNSIGNED_INT_IMAGE_1D_ARRAY" value="0x9068"/>
> +<enum name="UNSIGNED_INT_IMAGE_2D_ARRAY" value="0x9069"/>
> +<enum name="UNSIGNED_INT_IMAGE_CUBE_MAP_ARRAY" value="0x906A"/>
> +<enum name="UNSIGNED_INT_IMAGE_2D_MULTISAMPLE" value="0x906B"/>
> +<enum name="UNSIGNED_INT_IMAGE_2D_MULTISAMPLE_ARRAY" value="0x906C"/>
> +<enum name="MAX_IMAGE_SAMPLES" value="0x906D"/>
> +<enum name="IMAGE_BINDING_FORMAT" value="0x906E"/>
> +<enum name="IMAGE_FORMAT_COMPATIBILITY_TYPE" value="0x90C7"/>
> +<enum name="IMAGE_FORMAT_COMPATIBILITY_BY_SIZE" value="0x90C8"/>
> +<enum name="IMAGE_FORMAT_COMPATIBILITY_BY_CLASS" value="0x90C9"/>
> +<enum name="MAX_VERTEX_IMAGE_UNIFORMS" value="0x90CA"/>
> +<enum name="MAX_TESS_CONTROL_IMAGE_UNIFORMS" value="0x90CB"/>
> +<enum name="MAX_TESS_EVALUATION_IMAGE_UNIFORMS" value="0x90CC"/>
> +<enum name="MAX_GEOMETRY_IMAGE_UNIFORMS" value="0x90CD"/>
> +<enum name="MAX_FRAGMENT_IMAGE_UNIFORMS" value="0x90CE"/>
> +<enum name="MAX_COMBINED_IMAGE_UNIFORMS" value="0x90CF"/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131206/0d7b0334/attachment.html>