[Mesa-dev] [PATCH V2 01/10] mesa: Add infrastructure for GL_ARB_clear_buffer_object

[Pi Tabred]

On 12.12.2013 01:39, Brian Paul wrote:
> On 12/11/2013 02:55 PM, Pi Tabred wrote:
>>   - add xml file for extension
>>   - add reference in gl_API.xml
>>   - add pointer to device driver function table
>>   - add new functions to list of available functions
> 
> Or "- update dispatch_sanity.cpp"
> 
> 
>> ---
>>   src/mapi/glapi/gen/ARB_clear_buffer_object.xml | 50
>> ++++++++++++++++++++++++++
>>   src/mapi/glapi/gen/gl_API.xml                  |  6 +++-
>>   src/mesa/main/dd.h                             |  5 +++
>>   src/mesa/main/tests/dispatch_sanity.cpp        |  4 +--
>>   4 files changed, 62 insertions(+), 3 deletions(-)
>>   create mode 100644 src/mapi/glapi/gen/ARB_clear_buffer_object.xml
>>
>> diff --git a/src/mapi/glapi/gen/ARB_clear_buffer_object.xml
>> b/src/mapi/glapi/gen/ARB_clear_buffer_object.xml
>> new file mode 100644
>> index 0000000..e7baf6f
>> --- /dev/null
>> +++ b/src/mapi/glapi/gen/ARB_clear_buffer_object.xml
>> @@ -0,0 +1,50 @@
>> +<?xml version="1.0"?>
>> +<!DOCTYPE OpenGLAPI SYSTEM "gl_API.dtd">
>> +
>> +<!-- Note: no GLX protocol info yet. -->
>> +
>> +
>> +<OpenGLAPI>
>> +
>> +<category name="GL_ARB_clear_buffer_object" number="121">
>> +
>> +    <function name ="ClearBufferData" offset="assign">
>> +        <param name="target" type="GLenum"/>
>> +        <param name="internalformat" type="GLenum"/>
>> +        <param name="format" type="GLenum"/>
>> +        <param name="type" type="GLenum"/>
>> +        <param name="data" type="const GLvoid *"/>
>> +    </function>
>> +
>> +    <function name ="ClearBufferSubData" offset="assign">
>> +        <param name="target" type="GLenum"/>
>> +        <param name="internalformat" type="GLenum"/>
>> +        <param name="offset" type="GLintptr"/>
>> +        <param name="size" type="GLsizeiptr"/>
>> +        <param name="format" type="GLenum"/>
>> +        <param name="type" type="GLenum"/>
>> +        <param name="data" type="const GLvoid *"/>
>> +    </function>
>> +
>> +<!--    <function name="ClearNamedBufferDataEXT" offset="assign"
>> es2="3.0">
>> +        <param name="buffer" type="GLuint"/>
>> +        <param name="internalformat" type="GLenum"/>
>> +        <param name="format" type="GLenum"/>
>> +        <param name="type" type="GLenum"/>
>> +        <param name="data" type="const GLvoid*"/>
> 
> Space before '*' just to be consistent (and below).
> 

the second two functions are mentioned in the spec but depend on
EXT_direct_state_access (which is not available in mesa yet).
That's why I included them here but commented them out. Is that ok? or
should I remove them?