[Mesa-dev] [PATCH 0/2] code de-duplication and non-pci support

Erik Faye-Lund kusmabite at gmail.com
Tue Dec 17 10:01:52 PST 2013


On Sat, Dec 14, 2013 at 8:28 PM, Rob Clark <robdclark at gmail.com> wrote:
> From: Rob Clark <robclark at freedesktop.org>
>
> It seems that over time, code related to finding driver name, dealing
> with pci-id table, etc, has been copy/pasted everywhere it was needed.
> Which is lame.  And annoying if you have a device which is not pci.
>
> This patchset refactors it out into a simple loader util lib which is
> statically linked wherever it is needed.  Perhaps there is some room
> for sharing other util bits (like _eglLog, perhaps) later.
>
> And once all this code is collected in one place, the 2nd patch only
> has to fix one place to add support for platform devices ;-)
>
> Rob Clark (2):
>   loader: refactor duplicated code into loader util lib
>   loader: fallback to drmGetVersion() for non-pci devices
>

Nice. I've replaced Thierry's patch that does the latter, but only for
GBM, and the result still works fine. So:

Tested-by: Erik Faye-Lund <kusmabite at gmail.com>


More information about the mesa-dev mailing list