[Mesa-dev] [PATCH 0/2] code de-duplication and non-pci support
Rob Clark
robdclark at gmail.com
Mon Dec 23 13:00:41 PST 2013
bump..
Any chance someone from the pci camp could have a look at this series?
Also, I'm not quite sure about other build systems (android.. and is
scons still a thing?).. something is probably needed for those, but I
wouldn't know how to build with either of those. But something like
this patchset is needed for those of us without PC (well, right now
freedreno, but there are a couple more that hopefully end up upstream
eventually). So would like to know how to move forward.
BR,
-R
On Tue, Dec 17, 2013 at 1:01 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
> On Sat, Dec 14, 2013 at 8:28 PM, Rob Clark <robdclark at gmail.com> wrote:
>> From: Rob Clark <robclark at freedesktop.org>
>>
>> It seems that over time, code related to finding driver name, dealing
>> with pci-id table, etc, has been copy/pasted everywhere it was needed.
>> Which is lame. And annoying if you have a device which is not pci.
>>
>> This patchset refactors it out into a simple loader util lib which is
>> statically linked wherever it is needed. Perhaps there is some room
>> for sharing other util bits (like _eglLog, perhaps) later.
>>
>> And once all this code is collected in one place, the 2nd patch only
>> has to fix one place to add support for platform devices ;-)
>>
>> Rob Clark (2):
>> loader: refactor duplicated code into loader util lib
>> loader: fallback to drmGetVersion() for non-pci devices
>>
>
> Nice. I've replaced Thierry's patch that does the latter, but only for
> GBM, and the result still works fine. So:
>
> Tested-by: Erik Faye-Lund <kusmabite at gmail.com>
More information about the mesa-dev
mailing list