[Mesa-dev] [Bug 73136] New: [BISECTED] commit "mesa: Dynamically allocate the storage for program local parameters." crashes Awesomenauts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73136

          Priority: medium
            Bug ID: 73136
          Assignee: mesa-dev at lists.freedesktop.org
           Summary: [BISECTED] commit "mesa: Dynamically allocate the
                    storage for program local parameters." crashes
                    Awesomenauts
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: alexandre.f.demers at gmail.com
          Hardware: Other
            Status: NEW
           Version: git
         Component: Mesa core
           Product: Mesa

Awesomenauts has been crashing on launch since a couple of weeks. I took time
to bisect and I found out tonight where it was coming from.

First bad commit is e5885c119de1e508099cc1111e1c9f8ff00fab88

mesa: Dynamically allocate the storage for program local parameters.
Author
Eric Anholt<eric at anholt.net>
Author date
9/20/13 1:13 PM
Parent
mesa: Remove PROGRAM_ENV_PARAM enum.


    mesa: Dynamically allocate the storage for program local parameters.

    The array was 64kb per struct gl_program, plus we statically stored a copy
    of one on disk for _mesa_DummyProgram.  Given that most struct gl_programs
    we generate are for GLSL shaders that don't have local parameters, this
    was a waste.

    Since you can store and fetch parameters beyond what the program actually
    uses, we do have to do a late allocation if necessary at
    GetProgramLocalParameter time.

    Reduces peak memory usage in the dota2 trace I made by 76MB (4.5%)

    Reviewed-by: Brian Paul <brianp at vmware.com>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>



Tested using latest code for drm and ddx from git on ArchLinux 64bit on an
HD6950

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131230/09fee711/attachment.html>