[Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

[Chris Forbes]

Ouch. Thanks for catching that -- are there any other similar things I
need to be aware of?

On Wed, Feb 13, 2013 at 8:19 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 02/08/2013 01:19 AM, Chris Forbes wrote:
>>
>> V2: - emit `sample` parameter properly for multisample texelFetch()
>>      - fix spurious whitespace change
>>      - introduce a new opcode ir_txf_ms rather than overloading the
>>        existing ir_txf further. This makes doing the right thing in
>>        the driver somewhat simpler.
>>
>> V3: - fix weird whitespace
>>
>> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
>> Reviewed-by: Eric Anholt <eric at anholt.net>
>> Reviewed-by: Paul Berry <stereotype441 at gmail.com>
>
>
> Hey Chris,
>
> This patch needs to update ir.cpp's tex_opcode_strs[].  Otherwise,
> MESA_GLSL=dump segfaults when trying to print the texturing opcode.
>
> Thanks again for your great work!
>
> --Ken
>