[Mesa-dev] [Bug 60737] In GLSL ES, a missing FS precision qualifier does not generate an error

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Feb 14 11:22:52 PST 2013


Paul Berry <stereotype441 at gmail.com> changed:

           What    |Removed                     |Added
           Priority|medium                      |low

--- Comment #2 from Paul Berry <stereotype441 at gmail.com> ---
(In reply to comment #1)
> Out of all of these problems, only problem 1 seems necessary to fix in the
> short run, since it is the only problem that would cause Mesa to reject an
> otherwise-correct shader.  I have a patch out on the mailing list to fix it
> (http://lists.freedesktop.org/archives/mesa-dev/2013-February/034481.html). 
> Once that patch lands I'll downgrade the priority of this bug appropriately.

Ok, that patch has landed:

commit d5948f2f5e37d1abc0d433ddf43407d87b2d1227
Author: Paul Berry <stereotype441 at gmail.com>
Date:   Tue Feb 12 12:36:41 2013 -0800

    glsl: Allow default precision qualifiers to be set for sampler types.

    From GLSL ES 3.00 section 4.5.4 ("Default Precision Qualifiers"):

        "The precision statement

            precision precision-qualifier type;

        can be used to establish a default precision qualifier. The type
        field can be either int or float or any of the sampler types, and
        the precision-qualifier can be lowp, mediump, or highp."

    GLSL ES 1.00 has similar language.  GLSL 1.30 doesn't allow precision
    qualifiers on sampler types, but this seems like an oversight (since
    the intention of including these in GLSL 1.30 is to allow
    compatibility with ES shaders).

    Previously, Mesa followed GLSL 1.30 and only allowed default precision
    qualifiers to be set for float and int.  This patch makes it follow
    GLSL ES rules in all cases.

    Fixes Piglit tests default-precision-sampler.{vert,frag}.

    Partially addresses https://bugs.freedesktop.org/show_bug.cgi?id=60737.

    NOTE: This is a candidate for stable branches.

    Reviewed-by: Eric Anholt <eric at anholt.net>

The remaining problems are lower priority, hence I'm lowering the priority of
this bug.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130214/397f594a/attachment-0001.html>

More information about the mesa-dev mailing list