[Mesa-dev] [Bug 61091] u_blitter only works on drivers that ignore pipe_sampler_state.normalized_coords

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=61091

José Fonseca <jfonseca at vmware.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker
           Priority|medium                      |high
           Assignee|mesa-dev at lists.freedesktop. |maraeo at gmail.com
                   |org                         |
                 CC|                            |brianp at vmware.com,
                   |                            |jfonseca at vmware.com,
                   |                            |sroland at vmware.com
            Summary|piglit                      |u_blitter only works on
                   |glsl-fs-texture2drect       |drivers that ignore
                   |regression                  |pipe_sampler_state.normaliz
                   |                            |ed_coords

--- Comment #2 from José Fonseca <jfonseca at vmware.com> ---
(In reply to comment #1)
> glBlitFramebuffer with rectangle textures is also broken with both softpipe
> and llvmpipe and it has been so for quite a while. I have a piglit test for
> that.

The problem is that u_blitter is misleading drivers: it always sets
sampler_state.normalized_coords = 1, but then passes unnormalized coords for
rectangle textures.

It effectively only works on drivers that ignore normalized_coords.

If you prefer passing unnormalized coord then please fix the state.
Alternatively we could easily modify u_blitter to always pass normalized
coords.

Another thing to consider is just remove normalized_coords state, and force
drivers follow the texture target.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130222/0204df40/attachment-0001.html>