[Mesa-dev] [PATCH] configure.ac: Remove space after indent -T flag.

Vinson Lee vlee at freedesktop.org
Tue Jan 1 16:17:15 PST 2013


On Mon, Dec 31, 2012 at 5:31 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Dec 31, 2012 at 3:27 PM, Vinson Lee <vlee at freedesktop.org> wrote:
>> Fixes this build error on platforms not using GNU indent.
>>
>> indent: Command line: ``-T'' requires a parameter
>>
>> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 1294740..87bb71f 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -73,7 +73,7 @@ AC_PATH_PROG([PERL], [perl])
>>
>>  AC_CHECK_PROG(INDENT, indent, indent, cat)
>>  if test "x$INDENT" != "xcat"; then
>> -    AC_SUBST(INDENT_FLAGS, '-i4 -nut -br -brs -npcs -ce -T GLubyte -T GLbyte -T Bool')
>> +    AC_SUBST(INDENT_FLAGS, '-i4 -nut -br -brs -npcs -ce -TGLubyte -TGLbyte -TBool')
>>  fi
>>
>>  dnl Our fallback install-sh is a symlink to minstall. Use the existing
>> --
>> 1.8.0
>
> Fine by me. I've seen a report that -brs is a GNU-only option and
> doesn't work with BSD indent. What indent are you using that doesn't
> accept the space after -T but does accept -brs?
>
> https://bugs.gentoo.org/show_bug.cgi?id=428112

I get the indent-related build failure on Mac OS X and FreeBSD. On
both these platforms, indent does not have a -brs option. However, it
appears that -brs or any -brX option is equivalent to -br.


More information about the mesa-dev mailing list