[Mesa-dev] [PATCH] i965/fs: Remove force_sechalf stack.

Eric Anholt eric at anholt.net
Mon Jan 7 23:29:09 PST 2013


Kenneth Graunke <kenneth at whitecape.org> writes:

> Only Gen4 color write setup uses the force_sechalf flag, and it only
> sets it on a single instruction.  It also already has to get a pointer
> to the instruction and manually set the saturate flag, so we may as well
> just set force_sechalf the same way and avoid the complexity of a stack.

Mostly I was just following the pattern we had from brw_eu_emit.c, but
now that the code's written it doesn't make much sense (turns out when
we do sechalf, we do it at emit time not at vistor time, with that one
exception).

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130107/456686d5/attachment.pgp>


More information about the mesa-dev mailing list