[Mesa-dev] [PATCH] i965: Add break statement at end of BRW_OPCODE_CONTINUE case.

[Paul Berry]

This looks correct to me.

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


On 1 January 2013 17:06, Vinson Lee <vlee at freedesktop.org> wrote:

> Fixes missing break in switch defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/mesa/drivers/dri/i965/brw_eu_emit.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c
> b/src/mesa/drivers/dri/i965/brw_eu_emit.c
> index 8a93ced..bd9c182 100644
> --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
> +++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
> @@ -2397,6 +2397,7 @@ brw_set_uip_jip(struct brw_compile *p)
>
>          assert(insn->bits3.break_cont.uip != 0);
>          assert(insn->bits3.break_cont.jip != 0);
> +        break;
>
>        case BRW_OPCODE_ENDIF:
>           if (block_end_ip == 0)
> --
> 1.8.0.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130101/2884c353/attachment.html>