[Mesa-dev] [PATCH] i965: Add break statement at end of BRW_OPCODE_CONTINUE case.

[Kenneth Graunke]

On 01/01/2013 05:06 PM, Vinson Lee wrote:
> Fixes missing break in switch defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/mesa/drivers/dri/i965/brw_eu_emit.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
> index 8a93ced..bd9c182 100644
> --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
> +++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
> @@ -2397,6 +2397,7 @@ brw_set_uip_jip(struct brw_compile *p)
>
>   	 assert(insn->bits3.break_cont.uip != 0);
>   	 assert(insn->bits3.break_cont.jip != 0);
> +	 break;
>
>         case BRW_OPCODE_ENDIF:
>            if (block_end_ip == 0)

Crud, that's really bad.  Thanks for the fix.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>