[Mesa-dev] [PATCH 19/23] i965 teximage: don't call _mesa_store_teximage if format/type==GL_NONE

Eric Anholt eric at anholt.net
Wed Jan 9 11:11:13 PST 2013

Jordan Justen <jordan.l.justen at intel.com> writes:

> Mesa core's copyteximage calls the driver with format/type==GL_NONE
> to "Allocate texture memory". In this case, we shouldn't call
> _mesa_store_teximage.

I'm not sure if GL_NONE/GL_NONE really makes sense to test for here.  I
bet the actual problem is that the app's pixel unpack state (like having
a PBO bound, and thus pixels == NULL still meaning to upload data) is
leaking into this path through the use of &ctx->Unpack instead of
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130109/bd411ab6/attachment.pgp>

More information about the mesa-dev mailing list