[Mesa-dev] [PATCH 19/23] i965 teximage: don't call _mesa_store_teximage if format/type==GL_NONE

[Jordan Justen]

On Wed, Jan 9, 2013 at 11:11 AM, Eric Anholt <eric at anholt.net> wrote:
> Jordan Justen <jordan.l.justen at intel.com> writes:
>
>> Mesa core's copyteximage calls the driver with format/type==GL_NONE
>> to "Allocate texture memory". In this case, we shouldn't call
>> _mesa_store_teximage.
>
> I'm not sure if GL_NONE/GL_NONE really makes sense to test for here.  I
> bet the actual problem is that the app's pixel unpack state (like having
> a PBO bound, and thus pixels == NULL still meaning to upload data) is
> leaking into this path through the use of &ctx->Unpack instead of
> ctx->DefaultPacking.

There is an assert during the _mesa_store_teximage, because at some
point someone tries to get the bytes/pixel of GL_NONE/GL_NONE.
(Indeed, a few levels under a call to _mesa_validate_pbo_teximage).

I'm not sure I understand your alternative approach to fix this.

-Jordan