[Mesa-dev] [PATCH (gles3) 00/20] i965: Implement GLSL ES 3.00 pack/unpack functions (v2)

[Paul Berry]

On 21 January 2013 00:49, Chad Versace <chad.versace at linux.intel.com> wrote:

> This series lives on my gles3-glsl-packing branch.
>
> I tested this series against my piglit gles3-glsl-packing branch on
> Ivybridge
> and Sandybridge.  No regressions relative to the Mesa gles3-d72ba278e.
>
> v2:
>   - Do all of idr's minor fixes.
>   - Improve the rounding bias in _mesa_float_to_half.
>   - For evaluating constant pack/unpackHalf2x16 expressions, use
>     _mesa_float_to_half/_mesa_half_to_float [for idr].
>   - Add a bunch of new stuff to ir_builder.
>   - Rewrite the lowering pass using ir_builder [for idr].
>   - In lowering packHalf2x16, don't truncate subnormal float16 values to
> zero.
>     And round to even rather than to zero. [for stereotype441]
>
>
> Chad Versace (20):
>   glsl: Fix typo in comment
>   glsl: Add IR lisp for GLSL ES 3.00 pack/unpack functions
>   glsl: Extend ir_expression_operation for GLSL 3.00 pack/unpack
>     functions (v2)
>   glsl/standalone_scaffolding: Add stub for _mesa_warning()
>   mesa,glsl: Move round_to_even() from glsl to mesa/main
>   mesa: Remove rounding bias in _mesa_float_to_half()
>   glsl: Evaluate constant GLSL ES 3.00 pack/unpack expressions (v2)
>   glsl/ir_factory: Initialize members to NULL in constructor
>   glsl/ir_builder: Add more helpers for constructing expressions
>   glsl/ir_factory: Add helper method for making an ir_constant
>   glsl/ir_builder: Add `enum writemask`
>   glsl/ir_builder: Add helpers for making if-statements
>   glsl: Reformat and/or/xor cases in ir_expression ctor
>   glsl: Fix type-deduction for and/or/xor expressions
>   glsl: Add lowering pass for GLSL ES 3.00 pack/unpack operations (v2)
>   i965: Lower the GLSL ES 3.00 pack/unpack operations (v2)
>   i965: Add opcodes for F32TO16 and F16TO32
>   i965: Quote the PRM on a HorzStride subtlety
>   i965/vs/gen7: Emit code for GLSL ES 3.00 pack/unpack operations
>   i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations (v2)
>

I've already sent comments on patches 6, 7, and 15.

Patches 1-3, 5, 8-14, 16, and 18 are:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>

Patches 4 and 17 are:

Acked-by: Paul Berry <stereotype441 at gmail.com>

I'll try to look at patches 19 and 20 tomorrow morning.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130122/e70d802f/attachment.html>