[Mesa-dev] [PATCH 1/2] i965/vs/gen7: Emit code for GLSL ES 3.00 pack/unpack operations (v3)

Eric Anholt eric at anholt.net
Thu Jan 24 15:48:57 PST 2013


Chad Versace <chad.versace at linux.intel.com> writes:

> FIXME: This patch emits VS code that violates documented hardware restrictions
> and then relies on undocumented behavior that results from that violation.
> This patch passes all tests, but should be fixed ASAP to conform to the
> hardware documentation.

> +   case ir_unop_pack_snorm_2x16:
> +   case ir_unop_pack_unorm_2x16:
> +   case ir_unop_unpack_snorm_2x16:
> +   case ir_unop_unpack_unorm_2x16:
> +      assert(!"not reached: should be handled by lower_packing_builtins");
> +      break;
> +   case ir_unop_unpack_half_2x16_split_x:
> +   case ir_unop_unpack_half_2x16_split_y:
> +   case ir_binop_pack_half_2x16_split:
> +           assert(!"not reached: should not occur in vertex shader");
> +           break;

wacky whitespace.  Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130124/f2b92a6a/attachment.pgp>


More information about the mesa-dev mailing list