[Mesa-dev] [PATCH] android: fix stride to be bytes instead of pixels

Eric Anholt eric at anholt.net
Fri Jan 25 09:49:29 PST 2013

Tapani Pälli <tapani.palli at intel.com> writes:

> commit 60894edeef973e86a73067276f658b72f84271b6 changed the way dri2
> buffer pitch is interpreted in intel driver createImageFromName
> implementation, caller must set pitch in bytes, not pixels.

Oops, I didn't mean to change behavior of the interface.  It looks like
dri2_create_image_khr_pixmap() is also passing in a number of pixels.  I
can't tell on dri2_create_image_mesa_drm_buffer().

Since it's an interface breakage, so I think we should fix it on the
intel driver side, unless krh agrees that this is the intended interface
all along and that we don't care about new libGL vs old Intel drivers in
this particular case.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130125/c1bd3a52/attachment.pgp>

More information about the mesa-dev mailing list