[Mesa-dev] [PATCH] android: fix stride to be bytes instead of pixels

Tapani Pälli tapani.palli at intel.com
Sun Jan 27 22:53:40 PST 2013

On 01/25/2013 07:49 PM, Eric Anholt wrote:
> Tapani Pälli <tapani.palli at intel.com> writes:
>> commit 60894edeef973e86a73067276f658b72f84271b6 changed the way dri2
>> buffer pitch is interpreted in intel driver createImageFromName
>> implementation, caller must set pitch in bytes, not pixels.
> Oops, I didn't mean to change behavior of the interface.  It looks like
> dri2_create_image_khr_pixmap() is also passing in a number of pixels.  I
> can't tell on dri2_create_image_mesa_drm_buffer().
> Since it's an interface breakage, so I think we should fix it on the
> intel driver side, unless krh agrees that this is the intended interface
> all along and that we don't care about new libGL vs old Intel drivers in
> this particular case.

Right, this is how I figured it looked. Current createImageFromName in 
dri_interface.h uses pixels. I'll send a fix to Intel driver.

// Tapani

More information about the mesa-dev mailing list