[Mesa-dev] [PATCH RFC 1/3] glsl ES: Fix magnitude of gl_MaxVertexUniformVectors.

[Ian Romanick]

On 07/08/2013 10:40 AM, Paul Berry wrote:
> Previously, we set it equal to MaxVertexUniformComponents.  It should
> be MaxVertexUniformComponents / 4.
>
> NOTE: This is a candidate for the stable branches.
>
> Cc: mesa-stable at lists.freedesktop.org

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>   src/glsl/builtin_variables.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp
> index f4ac205..58019c6 100644
> --- a/src/glsl/builtin_variables.cpp
> +++ b/src/glsl/builtin_variables.cpp
> @@ -533,7 +533,7 @@ generate_common_ES_uniforms(exec_list *instructions,
>      add_builtin_constant(instructions, symtab, "gl_MaxVertexAttribs",
>   			state->Const.MaxVertexAttribs);
>      add_builtin_constant(instructions, symtab, "gl_MaxVertexUniformVectors",
> -			state->Const.MaxVertexUniformComponents);
> +			state->Const.MaxVertexUniformComponents / 4);
>      add_builtin_constant(instructions, symtab, "gl_MaxVertexTextureImageUnits",
>   			state->Const.MaxVertexTextureImageUnits);
>      add_builtin_constant(instructions, symtab, "gl_MaxCombinedTextureImageUnits",
>