[Mesa-dev] [PATCH 1/3] gallium/docs: clarify definition of PIPE_CAP_USER_CONSTANT_BUFFERS

Marek Olšák maraeo at gmail.com
Thu Jul 25 08:56:45 PDT 2013


Reviewed-by: Marek Olšák <maraeo at gmail.com>

Marek

On Thu, Jul 25, 2013 at 5:32 PM, Brian Paul <brianp at vmware.com> wrote:
> The cap means _can_ accept user-space constant buffers; it doesn't
> mean _only_ accepts user-space constant buffers.
> ---
>  src/gallium/docs/source/screen.rst |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst
> index 60c9af1..9b67b54 100644
> --- a/src/gallium/docs/source/screen.rst
> +++ b/src/gallium/docs/source/screen.rst
> @@ -119,9 +119,10 @@ The integer capabilities:
>  * ``PIPE_CAP_USER_INDEX_BUFFERS``: Whether user index buffers are supported.
>    If not, the state tracker must upload all indices which are not in hw
>    resources.
> -* ``PIPE_CAP_USER_CONSTANT_BUFFERS``: Whether user constant buffers are
> -  supported. If not, the state tracker must upload constants which are not in hw
> -  resources.
> +* ``PIPE_CAP_USER_CONSTANT_BUFFERS``: Whether user-space constant buffers
> +  are supported.  If not, the state tracker must put constants into HW
> +  resources/buffers.  If user-space constant buffers are supported, the
> +  driver must still accept HW constant buffers also.
>  * ``PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT``: Describes the required
>    alignment of pipe_constant_buffer::buffer_offset.
>  * ``PIPE_CAP_START_INSTANCE``: Whether the driver supports
> --
> 1.7.10.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list