[Mesa-dev] [PATCH 1/4] mesa: Remove stray debug printfs in attachment completeness code

Kenneth Graunke kenneth at whitecape.org
Sun Jul 28 16:06:36 PDT 2013


On 07/28/2013 12:56 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>   src/mesa/main/fbobject.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index 29c3c50..a55b56c 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -703,8 +703,6 @@ test_attachment_completeness(const struct gl_context *ctx, GLenum format,
>         }
>         if (texImage->Width < 1 || texImage->Height < 1) {
>            att_incomplete("teximage width/height=0");
> -         printf("texobj = %u\n", texObj->Name);
> -         printf("level = %d\n", att->TextureLevel);
>            att->Complete = GL_FALSE;
>            return;
>         }

I second Chris's concern with patch 3.  Assuming that's taken care of,

Patches 1-4 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Patch 5 is:
Acked-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list