[Mesa-dev] [PATCH] i965: Fix glColorPointer(GL_FIXED)

[Chad Versace]

On 06/03/2013 01:02 PM, Eric Anholt wrote:
> Chad Versace <chad.versace at linux.intel.com> writes:
>
>> When a gl_client_array is created with glColorPointer,
>> gl_client_array::Normalized is true. This caused the translation from the
>> gl_client_array's type to a BRW_SURFACEFORMAT to assertion fail.
>>
>> Fixes the spinning cube's color in Android 4.2's ApiDemos.apk,
>> "Graphics > OpenGL ES".
>>
>> Fixes assertion failure in mesa-demos/src/egl/opengles1/tri_x11 on Haswell
>> and Ivybridge:
>>    brw_draw_upload.c:287: get_surface_type: Assertion `0' failed.
>>
>> No Piglit regressions on Haswell.
>
> We seriously need a piglit test for this.  I'm only very reluctangly
> offering a:
>
> Reviewed-by: Eric Anholt <eric at anholt.net>

Piglit test is now coming soon.