[Mesa-dev] [PATCH v3] Rename the _mesa_lookup_enum_by_nr() function Renamed function _mesa_lookup_prim_by_nr() to _mesa_prim_string() _mesa_lookup_enum_by_nr() to _mesa_enum_string() _mesa_lookup_enum_by_name() to _mesa_enum_value() Changes were made, because nobody liked the way these functions are called.

Arnas Milaševičius giant1gf at gmail.com
Thu Jun 6 01:44:57 PDT 2013

It seems that you didn't understand me or I didn't undrstand you. For
example gl_enums.py has all the 3 functions. How do I deal with that
file? I don't thing it's the right way to change for example
_mesa_lookup_prim_by_nr() there, then send this patch, then change
back from _mesa_prim_string() to _mesa_lookup_prim_by_nr() and
change_mesa_lookup_enum_by_nr() in the same file. If I change all the
3 functions in the same file, how am I going to commit this change? "I
basically changed _mesa_lookup_prim_by_nr() function in every file,
but I also changed this and this function in that and that file,
because they were together with _mesa_lookup_prim_by_nr() function." I
think this patch is good and shouldn't be seperated into 3 parts.

On Thu, Jun 6, 2013 at 1:17 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 06/05/2013 03:02 PM, Arnas Milaševičius wrote:
>> And how should I deal with the files, which has all the 3 functions in
>> them? Should I add them in one of the 3 patches or should I add them in
>> all the 3 patches?
> Each of the three patches should change whatever files are necessary.
> i.e.
> search and replace _mesa_lookup_prim_by_nr(), git commit -a
> search and replace _mesa_lookup_enum_by_nr(), git commit -a
> search and replace _mesa_lookup_enum_by_name(), git commit -a
> Most of the files will probably be changed by all three commits.

More information about the mesa-dev mailing list