[Mesa-dev] [PATCH v3] Rename the _mesa_lookup_enum_by_nr() function Renamed function _mesa_lookup_prim_by_nr() to _mesa_prim_string() _mesa_lookup_enum_by_nr() to _mesa_enum_string() _mesa_lookup_enum_by_name() to _mesa_enum_value() Changes were made, because nobody liked the way these functions are called.

Tormod Volden lists.tormod at gmail.com
Thu Jun 6 04:05:00 PDT 2013

On Thu, Jun 6, 2013 at 10:44 AM, Arnas Milaševičius wrote:
> It seems that you didn't understand me or I didn't undrstand you. For
> example gl_enums.py has all the 3 functions. How do I deal with that
> file? I don't thing it's the right way to change for example
> _mesa_lookup_prim_by_nr() there, then send this patch, then change
> back from _mesa_prim_string() to _mesa_lookup_prim_by_nr() and
> change_mesa_lookup_enum_by_nr() in the same file. If I change all the
> 3 functions in the same file, how am I going to commit this change? "I
> basically changed _mesa_lookup_prim_by_nr() function in every file,
> but I also changed this and this function in that and that file,
> because they were together with _mesa_lookup_prim_by_nr() function." I
> think this patch is good and shouldn't be seperated into 3 parts.

If you do as Kenneth suggests you will have three patches that you can
send to the list. If the patches touch different parts of the same
file they are independent (line number changes are easily sorted out
by whatever tool the committer will use). If two patches touch the
very same part of one file, they may not be independent of each other
but the second will depend on the first. This is very common and
totally normal. Usually you will send the patches as a patch series in
this case. For instance, "git format-patch -o /tmp origin/master" will
make such a series out of all the commits you have made on top of


More information about the mesa-dev mailing list