[Mesa-dev] recursive raytracing demo

[kristof.ralovich at gmail.com]

On Mon, Apr 29, 2013 at 4:21 PM, Brian Paul <brianp at vmware.com> wrote:
> On 04/28/2013 06:54 AM, kristof.ralovich at gmail.com wrote:
>>
>> Dear All,
>>
>> please review and merge this demo.
>
>
> In patch 2:
>
> * Let's pass the GS input/output info as parameters to the function and
> rename it to something like LinkShadersWithGeometryInfo().  Then we can
> re-use the function in some of the other geometry shader demos.

Done.

>
> * Use 3-space indentation, not 2-space.
>

Done.

>
> In patch 3:
>
> I just skimmed it, but:
> * Please update Makefile.am also (I'm attaching the patch that worked for
> me, but I'm not 100% sure it's correct with respect to the
> gsraytrace_SOURCES line.  The .cpp file isn't found otherwise).

Included your patch, but haven't tested it.

> * 3-space indentation, please.
> * Maybe add some comments at the top of the file explaining the demo.

Done, referring to conference article.

> * I tried the demo with my NVIDIA driver but it crashes:
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x000000004007ceb1 in ?? ()
> Missing separate debuginfos, use: debuginfo-install glibc-2.12.2-1.x86_64
> glibc-2.12.90-17.x86_64 libICE-1.0.6-2.fc13.x86_64 libSM-1.1.0-7.fc12.x86_64
> libX11-1.3.1-3.fc13.x86_64 libX11-1.3.4-3.fc14.x86_64
> libXau-1.0.5-1.fc12.x86_64 libXau-1.0.6-1.fc14.x86_64
> libXext-1.1-2.fc13.x86_64 libXext-1.1.2-2.fc14.x86_64
> libXi-1.3-2.fc13.x86_64 libXi-1.3.2-1.fc14.x86_64 libXmu-1.0.5-2.fc13.x86_64
> libXt-1.0.7-1.fc13.x86_64 libgcc-4.4.4-10.fc13.x86_64
> libgcc-4.5.1-4.fc14.x86_64 libselinux-2.0.90-5.fc13.x86_64
> libselinux-2.0.96-5.fc14.x86_64 libstdc++-4.4.4-10.fc13.x86_64
> libstdc++-4.5.1-4.fc14.x86_64 libuuid-2.17.2-5.fc13.x86_64
> libuuid-2.18-4.3.fc14.x86_64 libxcb-1.5-1.fc13.x86_64
> libxcb-1.7-1.fc14.x86_64 mesa-libGLU-7.9-1.fc14.x86_64
> (gdb) where
> #0  0x000000004007ceb1 in ?? ()
> #1  0x0000000040000000 in ?? ()
> #2  0x00007ffff713c000 in ?? ()
> #3  0x0000000000400000 in ?? ()
> #4  0x0000000040000000 in ?? ()
> #5  0x00000032190f30df in ?? () from /usr/lib64/libnvidia-glcore.so.295.33
> #6  0x0000000000403238 in Draw () at gsraytrace.cpp:649
> #7  0x000000375ba23258 in idleWait () at glut_event.c:972
> #8  0x000000375ba23dbc in glutMainLoop () at glut_event.c:1381
> #9  0x000000000040394d in main (argc=1, argv=<value optimized out>) at
> gsraytrace.cpp:936
>
> What GPU/driver did you test with?

The crash under nvidia linux driver was due to Reshape() not being
called before rendering, and thus the BO-s were not created. Fixed
patches.

>
> -Brian

Please review and apply.

Thanks,
Kristof
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-util-generalize-linking-geometry-shaders-allow-cxx-i.patch
Type: application/octet-stream
Size: 2787 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130612/e09f774c/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-glsl-gsraytrace-recursive-ray-tracing-in-gemetry-sha.patch
Type: application/octet-stream
Size: 46342 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130612/e09f774c/attachment-0003.obj>