[Mesa-dev] [PATCH 5/6] mesa: Fix missing setting of shader->IsES.

[Kenneth Graunke]

On 06/19/2013 03:57 PM, Eric Anholt wrote:
> Kenneth Graunke <kenneth at whitecape.org> writes:
>
>> On 06/17/2013 04:10 PM, Eric Anholt wrote:
>>> I noticed this while trying to merge code with the builtin compiler, which
>>> does set it.
>>>
>>> Note that this causes two regressions in piglit in
>>> default-precision-sampler.* which try to link without a vertex or fragment
>>> shader, due to being run under the desktop glslparsertest binary (using
>>> ARB_ES3_compatibility) that doesn't know about this requirement.
>>
>> That seems quite odd.
>
> There are ifdefs in glslparsertest for adding appropriate stub shaders
> for ES in an ES build, but if you run in ES3 compat on a desktop build,
> it doesn't happen.  We should just be running these tests in the ES
> build.

I don't think that's true - glslparsertest in master only appears to add 
stub shaders if the requested language version is 100.  Presumably it 
ought to do the same for 300 es.

Only running the tests on the actual ES3 api seems reasonable too, but 
I'm not sure it would fix the problem.

--Ken