[Mesa-dev] [PATCH 5/6] mesa: Fix missing setting of shader->IsES.

Eric Anholt eric at anholt.net
Wed Jun 19 15:57:23 PDT 2013


Kenneth Graunke <kenneth at whitecape.org> writes:

> On 06/17/2013 04:10 PM, Eric Anholt wrote:
>> I noticed this while trying to merge code with the builtin compiler, which
>> does set it.
>>
>> Note that this causes two regressions in piglit in
>> default-precision-sampler.* which try to link without a vertex or fragment
>> shader, due to being run under the desktop glslparsertest binary (using
>> ARB_ES3_compatibility) that doesn't know about this requirement.
>
> That seems quite odd.

There are ifdefs in glslparsertest for adding appropriate stub shaders
for ES in an ES build, but if you run in ES3 compat on a desktop build,
it doesn't happen.  We should just be running these tests in the ES
build.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130619/98dd4c4a/attachment.pgp>


More information about the mesa-dev mailing list