[Mesa-dev] [PATCH] Add missing GL_TEXTURE_CUBE_MAP entry in _mesa_legal_texture_dimensions

[Ian Romanick]

On 03/05/2013 07:09 AM, Brian Paul wrote:
> On 03/05/2013 05:08 AM, Alan Hourihane wrote:
>> Add's the missing GL_TEXTURE_CUBE_MAP entry in
>> _mesa_legal_texture_dimensions.
>>
>> Signed-off-by: Alan Hourihane <alanh at vmware.com>
>> ---
>> src/mesa/main/teximage.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
>> index 0dcf88a..9d4a170 100644
>> --- a/src/mesa/main/teximage.c
>> +++ b/src/mesa/main/teximage.c
>> @@ -1416,6 +1416,7 @@ _mesa_legal_texture_dimensions(struct gl_context
>> *ctx, GLenum target,
>> return GL_FALSE;
>> return GL_TRUE;
>>
>> + case GL_TEXTURE_CUBE_MAP:
>> case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
>> case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
>> case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
>
> It looks like this would be hit via glTexStorage2D(), right?

If that's the case, could that get added to the commit message?  It 
wasn't obvious to me why it was needed.

> Could you add "Note: this is a candidate for the stable branches"?
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev