[Mesa-dev] [PATCH 2/2] configure.ac: Build dricommon when dri is enabled

Carl Worth cworth at cworth.org
Tue Mar 5 16:08:23 PST 2013

Matt Turner <mattst88 at gmail.com> writes:
> Commit 67ef7559 added an || test "x$enable_dri" check, which was just
> wrong since the whole block was enclosed in if test "x$enable_dri". The
> comment added with it stated the actual intent: to enable when any DRI
> drivers were built.

Thanks, Matt.

I've tested this and it fixes the failure reported in the
recently-reopened bug 59261 and also fixes the failure reported in bug

You might add a bit more of the story to the commit message. Here is
my attempt based on what I've been able to decipher:

  Commit 67ef7559 added an || test "x$enable_dri" check in an attempt to
  get the DRI common bits built in some necessary cases. That change was
  inappropriate as it made these common DRI pieces be built
  unconditionally, so some builds were broken.

  Subsequently, commit 998d975e3 change the "|| test" to a "-a"
  conjunction within the existing test invocation. This made the '-a
  "x$enable_dri" = xyes' clause have no effect, (as it was inside an
  enclosing test for the same condition). So the new breakage from
  commit 67ef7559 was addressed, but the original problems were

  The immediately preceding commit removed the redundant condition.

  Now, finally this commit fixes the original problem as described in
  the commit message of 67ef7559: this code should be compiled when
  using the DRI state tracker.
  drivers were built.

Reviewed-by: Carl Worth <cworth at cworth.org>


carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130305/efa0f51e/attachment.pgp>

More information about the mesa-dev mailing list