[Mesa-dev] [PATCH 2/2] configure.ac: Build dricommon when dri is enabled

Matt Turner mattst88 at gmail.com
Tue Mar 5 16:25:52 PST 2013

On Tue, Mar 5, 2013 at 4:08 PM, Carl Worth <cworth at cworth.org> wrote:
> Matt Turner <mattst88 at gmail.com> writes:
>> Commit 67ef7559 added an || test "x$enable_dri" check, which was just
>> wrong since the whole block was enclosed in if test "x$enable_dri". The
>> comment added with it stated the actual intent: to enable when any DRI
>> drivers were built.
> Thanks, Matt.
> I've tested this and it fixes the failure reported in the
> recently-reopened bug 59261 and also fixes the failure reported in bug
> 61821.
> You might add a bit more of the story to the commit message. Here is
> my attempt based on what I've been able to decipher:
>   Commit 67ef7559 added an || test "x$enable_dri" check in an attempt to
>   get the DRI common bits built in some necessary cases. That change was
>   inappropriate as it made these common DRI pieces be built
>   unconditionally, so some builds were broken.
>   Subsequently, commit 998d975e3 change the "|| test" to a "-a"
>   conjunction within the existing test invocation. This made the '-a
>   "x$enable_dri" = xyes' clause have no effect, (as it was inside an
>   enclosing test for the same condition). So the new breakage from
>   commit 67ef7559 was addressed, but the original problems were
>   regressed.
>   The immediately preceding commit removed the redundant condition.
>   Now, finally this commit fixes the original problem as described in
>   the commit message of 67ef7559: this code should be compiled when
>   using the DRI state tracker.
>   drivers were built.
> Reviewed-by: Carl Worth <cworth at cworth.org>
> -Carl
> --
> carl.d.worth at intel.com

Thanks Carl. I'll use your commit message.

More information about the mesa-dev mailing list