[Mesa-dev] [PATCH V2 0/3] Sample count limit tidy-up

Kenneth Graunke kenneth at whitecape.org
Sat Mar 23 20:02:29 PDT 2013

On 03/23/2013 06:50 PM, Chris Forbes wrote:
> This series tidies up the missing interactions between unextended GL3,
> ARB_texture_multisample and ARB_internalformat_query.
> No serious functional changes from V1, just a lot of shuffling things around.
> -- Chris

I believe this will allow > 1 samples with depth formats on i965, since 
our implementation of the internalformat_query hook doesn't return 1 for 
depth textures.  That's a change in behavior, which is kind of lame.

IIRC the only reason we hadn't exposed 4/8 anyway is a lack of testing. 
  But we always need more texturing tests.

Unigine Valley seems to expect that if the number of color samples is > 
1, depth samples will also be > 1.  Otherwise, it hits FBO 
incompleteness errors and fails to render.  I bumped it to 8 on IVB and 
tried running it, and it seemed to work okay.

I'd say just go ahead with the bump and we can fix bugs if we find them.

Otherwise, this looks like a nice series - glad to see all that complex 
checking consolidated into one place.

For the series:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

More information about the mesa-dev mailing list