[Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

[Mike Lothian]

Sorry that patch doesn't fix the build

diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
--- a/src/gallium/state_trackers/clover/llvm/invocation.cpp     2013-03-29
12:14:25.514504748 +0000
+++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp     2013-03-29
12:13:03.978506530 +0000
@@ -37,7 +37,8 @@
 #include <llvm/IR/DerivedTypes.h>
 #include <llvm/IR/LLVMContext.h>
 #include <llvm/IR/Module.h>
-#include <llvm/Support/IRReader.h>
+#include <llvm/Support/SourceMgr.h>
+#include <llvm/IRReader/IRReader.h>
 #endif
 #include <llvm/PassManager.h>
 #include <llvm/Support/TargetSelect.h>


This one does however



On 29 March 2013 11:40, Mike Lothian <mike at fireburn.co.uk> wrote:

> Hi
>
> This include is also in
> src/gallium/state_trackers/clover/llvm/invocation.cpp
>
> diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
>  2013-03-29 11:15:52.851581526 +0000
> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp    2013-03-29
> 11:32:41.580559478 +0000
> @@ -37,7 +37,6 @@
>  #include <llvm/IR/DerivedTypes.h>
>  #include <llvm/IR/LLVMContext.h>
>  #include <llvm/IR/Module.h>
> -#include <llvm/Support/IRReader.h>
>  #endif
>  #include <llvm/PassManager.h>
>  #include <llvm/Support/TargetSelect.h>
>
> Cheers
>
> Mike
>
>
>
> On 26 March 2013 12:11, Christian König <deathsimple at vodafone.de> wrote:
>
>> Am 26.03.2013 12:53, schrieb Michel Dänzer:
>>
>>  On Die, 2013-03-26 at 11:56 +0100, Christian König wrote:
>>>
>>>> From: Christian König <christian.koenig at amd.com>
>>>>
>>>> The include isn't needed and the file has moved with LLVM master.
>>>>
>>>> Signed-off-by: Christian König <christian.koenig at amd.com>
>>>>
>>> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>>>
>>> The rest of the series seems unchanged, so my review of it stands.
>>>
>>
>> How about the LLVM changes? I know we could improve WQM now that it is in
>> the backend, but I would rather like to let it stay like this for another
>> round (as good or as bad as it is) and try to get this patchset committed
>> first.
>>
>> Christian.
>>
>> ______________________________**_________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/**mailman/listinfo/mesa-dev<http://lists.freedesktop.org/mailman/listinfo/mesa-dev>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130329/5572f314/attachment.html>