[Mesa-dev] [PATCH] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM >= 3.4.

[Alex Deucher]

On Mon, Nov 4, 2013 at 9:41 AM, Tom Stellard <tom at stellard.net> wrote:
> On Sun, Nov 03, 2013 at 08:35:47PM -0800, Vinson Lee wrote:
>> LLVM 3.4 r193971 removed llvm::DisablePrettyStackTrace and made the
>> pretty stack trace opt-in rather than opt-out.
>>
>
> Could you add a comment explaining that the default value of
> DisablePrettyStackTrace has changed to true in LLVM 3.4 and newer.
> Otherwise, I think people may be confused about why this change was
> made.
>
> With that change, the patch is:
>
> Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

Also apparently fixes this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=60929

Alex

>
>> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
>> ---
>>  src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
>> index e8d2db2..65c02d8 100644
>> --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
>> +++ b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
>> @@ -174,12 +174,14 @@ lp_set_target_options(void)
>>     }
>>  #endif
>>
>> +#if HAVE_LLVM < 0x0304
>>     /*
>>      * By default LLVM adds a signal handler to output a pretty stack trace.
>>      * This signal handler is never removed, causing problems when unloading the
>>      * shared object where the gallium driver resides.
>>      */
>>     llvm::DisablePrettyStackTrace = true;
>> +#endif
>>
>>     // If we have a native target, initialize it to ensure it is linked in and
>>     // usable by the JIT.
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev