[Mesa-dev] [PATCH] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM >= 3.4.

Brian Paul brianp at vmware.com
Mon Nov 4 06:58:02 PST 2013


On 11/03/2013 09:35 PM, Vinson Lee wrote:
> LLVM 3.4 r193971 removed llvm::DisablePrettyStackTrace and made the
> pretty stack trace opt-in rather than opt-out.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> index e8d2db2..65c02d8 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> @@ -174,12 +174,14 @@ lp_set_target_options(void)
>      }
>   #endif
>
> +#if HAVE_LLVM < 0x0304
>      /*
>       * By default LLVM adds a signal handler to output a pretty stack trace.
>       * This signal handler is never removed, causing problems when unloading the
>       * shared object where the gallium driver resides.
>       */
>      llvm::DisablePrettyStackTrace = true;
> +#endif
>
>      // If we have a native target, initialize it to ensure it is linked in and
>      // usable by the JIT.
>

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list