[Mesa-dev] [PATCH 1/2] i965: Allocate vec4_visitor's uniform_size and uniform_vector_size arrays dynamically.

Francisco Jerez currojerez at riseup.net
Fri Nov 22 11:49:11 PST 2013


Ian Romanick <idr at freedesktop.org> writes:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 11/22/2013 10:05 AM, Francisco Jerez wrote:
>>[...]
>> With the upcoming ARB_shader_image_load_store changes we might get
>> more than 4 * MAX_UNIFORM uniform allocations in some cases because
>> image uniforms can take up several slots for the image meta-data --
>> I think it would make sense to extend this change to the FS
>> back-end too.
>
> Do you think that should get done now or as a follow-on patch?  This
> fixes an existing problem, and I think we want a fix that can get
> picked to the 10.0 branch and possibly earlier stable branches.
>

I'm fine either way.  If you'd like to keep the bugfix as simple as
possible for the stable branch I can take care of the fs_visitor change
myself as a separate patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131122/d37d02ab/attachment.pgp>


More information about the mesa-dev mailing list