[Mesa-dev] [PATCH 1/8] mesa: expose AMD_vertex_shader_layer in the core profile only

[Ian Romanick]

On 11/24/2013 07:41 PM, Jordan Justen wrote:
> On Sun, Nov 24, 2013 at 2:55 AM, Marek Olšák <maraeo at gmail.com> wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> It needs glFramebufferTexture, which isn't available in the compatibility
>> profile.
>> ---
>>  src/mesa/main/extensions.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
>> index 104618c..f7e7e4d 100644
>> --- a/src/mesa/main/extensions.c
>> +++ b/src/mesa/main/extensions.c
>> @@ -300,7 +300,7 @@ static const struct extension extension_table[] = {
>>     { "GL_AMD_performance_monitor",                 o(AMD_performance_monitor),                 GL,             2007 },
>>     { "GL_AMD_seamless_cubemap_per_texture",        o(AMD_seamless_cubemap_per_texture),        GL,             2009 },
>>     { "GL_AMD_shader_stencil_export",               o(ARB_shader_stencil_export),               GL,             2009 },
>> -   { "GL_AMD_vertex_shader_layer",                 o(AMD_vertex_shader_layer),                 GL,             2012 },
>> +   { "GL_AMD_vertex_shader_layer",                 o(AMD_vertex_shader_layer),                 GLC,            2012 },
> 
> Seems fine, but not required.
> 
> This would need to be reverted if GS4 was made available in compat,
> which I don't think is currently planned.

True, but right now i965 (on master) will report
GL_AMD_vertex_shader_layer is supported in the 3.0 compatibility
profile, but apps can't actually use it.  We should either make this
extension core-only, as Marek has done, or add an extension that make
the other layer-related functionality available in pre-3.2 contexts, as
the AMD extension spec suggests.

Until someone does a bunch more work, this patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> -Jordan
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev