[Mesa-dev] [PATCH 5/6] glsl: Create an accessor for the built-in function shader.

Kenneth Graunke kenneth at whitecape.org
Wed Nov 27 10:47:13 PST 2013


On 11/23/2013 05:45 PM, Kenneth Graunke wrote:
> On 11/23/2013 04:03 PM, Ian Romanick wrote:
>> Would it be better to just make _mesa_glsl_get_builtin_function_shader a
>> friend?
> 
> In this case, I don't think it makes much practical difference - the
> builtin_builder class is entirely contained within the
> builtin_functions.cpp file.  So making this public is basically making
> all the ordinary functions at the bottom of the file friends, which
> seems fairly reasonable.
> 
> --Ken

Ian, after that answer, are you okay with the patch?  Or would you like
it changed?

--Ken



More information about the mesa-dev mailing list