[Mesa-dev] [PATCH V4 01/13] mesa: add texture gather changes

[Kenneth Graunke]

On 09/30/2013 03:08 AM, Chris Forbes wrote:
> From: Maxence Le Dore <maxence.ledore at gmail.com>
> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mapi/glapi/gen/ARB_texture_gather.xml | 14 ++++++++++++++
>  src/mapi/glapi/gen/gl_API.xml             |  2 +-
>  src/mesa/main/context.c                   |  4 ++++
>  src/mesa/main/extensions.c                |  1 +
>  src/mesa/main/get.c                       |  1 +
>  src/mesa/main/get_hash_params.py          |  6 ++++++
>  src/mesa/main/mtypes.h                    |  6 ++++++
>  src/mesa/main/tests/enum_strings.cpp      |  3 +++
>  8 files changed, 36 insertions(+), 1 deletion(-)
>  create mode 100644 src/mapi/glapi/gen/ARB_texture_gather.xml

Series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I'm fine with this landing.  I think the next step is to enable the
ARB_gpu_shader5 variants.  The workarounds are gross, but it's inherent
in the problem, and I don't think we're going to find much better.

Eventually I hope to shrink the binding tables, but I'm not too worried
for now...it at least gets the new feature working without adding cost
to existing programs that don't use it.  We can always optimize and tidy
things up once it's all in place.

Thanks for your work on this, Chris.

--Ken