[Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

[Kenneth Graunke]

On 10/08/2013 11:22 AM, Ian Romanick wrote:
> On 10/08/2013 10:36 AM, Eric Anholt wrote:
>> We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd
>> experimentally found to be necessary!), but while the spec still requires
>> it on gen5, we'd been missing it in the array-layout cubemaps.
> 
> I think we didn't bother with that patch because we only support
> GL_ARB_texture_cube_map_array on GEN6+.  While I think this is a
> reasonable change (keep the paths similar), I don't think it needs to be
> picked back to stable... unless there's a way I'm not seeing that could
> cause it to get hit...
> 
> For master,
> 
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Ian,

I believe this patch is about ordinary cube maps, not cube map arrays.

On Gen4, cube maps are stored similarly to 3D textures.

On Gen5+, cube maps are stored as 2D array textures, indexed by the cube
face.

It sounds like the fix Eric discovered for Gen4 cubemaps also applies to
Gen5+ cubemaps (even though they are layed out differently)

--Ken