[Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

Ian Romanick idr at freedesktop.org
Tue Oct 8 14:46:04 PDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/08/2013 01:28 PM, Eric Anholt wrote:
> Ian Romanick <idr at freedesktop.org> writes:
> 
>> On 10/08/2013 10:36 AM, Eric Anholt wrote:
>>> We had a fixup for gen4's 3d-layout cubemaps (which, iirc,
>>> we'd experimentally found to be necessary!), but while the spec
>>> still requires it on gen5, we'd been missing it in the
>>> array-layout cubemaps.
>> 
>> I think we didn't bother with that patch because we only support 
>> GL_ARB_texture_cube_map_array on GEN6+.  While I think this is a 
>> reasonable change (keep the paths similar), I don't think it
>> needs to be picked back to stable... unless there's a way I'm not
>> seeing that could cause it to get hit...
> 
> As of gen5, cube maps on all hardware are always laid out as
> arrays, not as weird 3d textures -- that's what I was referring
> to.

Oh, that's right.  Carry on. :)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)

iEYEARECAAYFAlJUfRwACgkQX1gOwKyEAw/xWgCeMoP1cO//JufiKBs37xJ9vPsm
aNAAn2FaP58e/R4C28Vq13lMlf4IK77V
=bHTO
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list