[Mesa-dev] [PATCH] i965/fs: Remove bogus field prog_data->dispatch_width.

Eric Anholt eric at anholt.net
Sat Oct 12 01:18:56 CEST 2013


Paul Berry <stereotype441 at gmail.com> writes:

> Despite the name, this field wasn't being set to the dispatch width at
> all; it was always 8.  The only place it was used was that the
> constant buffer read length was aligned to it, and as far as I can
> tell from the docs, there is no need to align this value to the
> dispatch width; aligning it to a multiple of 8 is sufficient.  So I've
> just replaced it with a hardcoded 8.

Reviewed-by: Eric Anholt <eric at anholt.net>

but I'd also r-b a patch that reused brw->wm.base.push_const_size in the
last hunk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131011/857b3e47/attachment.pgp>


More information about the mesa-dev mailing list