[Mesa-dev] [PATCH] i965/fs: Remove bogus field prog_data->dispatch_width.

Paul Berry stereotype441 at gmail.com
Tue Oct 15 20:33:53 CEST 2013


On 11 October 2013 16:18, Eric Anholt <eric at anholt.net> wrote:

> Paul Berry <stereotype441 at gmail.com> writes:
>
> > Despite the name, this field wasn't being set to the dispatch width at
> > all; it was always 8.  The only place it was used was that the
> > constant buffer read length was aligned to it, and as far as I can
> > tell from the docs, there is no need to align this value to the
> > dispatch width; aligning it to a multiple of 8 is sufficient.  So I've
> > just replaced it with a hardcoded 8.
>
> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> but I'd also r-b a patch that reused brw->wm.base.push_const_size in the
> last hunk.
>

Good idea--I like that even better.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131015/c7a22993/attachment.html>


More information about the mesa-dev mailing list