[Mesa-dev] [PATCH] i965: Implement ARB_texture_mirror_clamp.

[Rico Schüller]

I have one minor nitpick (see below). But either way, with the subject
fixed (as mentioned by Matt), this is:
Reviewed-by: Rico Schüller <kgbricola at web.de>

On 21.10.2013 07:24, Kenneth Graunke wrote:
> This passes Piglit's texwrap tests (after applying Rico's patch to
> make them use this extension).
> 
> Cc: Rico Schüller <kgbricola at web.de>
> Cc: Ian Romanick <idr at freedesktop.org>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_wm_sampler_state.c | 2 ++
>  src/mesa/drivers/dri/i965/intel_extensions.c     | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
> index b716d61..db7ab60 100644
> --- a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
> @@ -71,6 +71,8 @@ translate_wrap_mode(GLenum wrap, bool using_nearest)
>        return BRW_TEXCOORDMODE_CLAMP_BORDER;
>     case GL_MIRRORED_REPEAT: 
>        return BRW_TEXCOORDMODE_MIRROR;
> +   case GL_MIRROR_CLAMP_TO_EDGE_EXT:
> +      return BRW_TEXCOORDMODE_MIRROR_ONCE;
I'd prefer GL_MIRROR_CLAMP_TO_EDGE instead of
GL_MIRROR_CLAMP_TO_EDGE_EXT but as it is the same value it really
shouldn't matter.

>     default: 
>        return BRW_TEXCOORDMODE_WRAP;
>     }
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c
> index 803d090..87cc87d 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -75,6 +75,7 @@ intelInitExtensions(struct gl_context *ctx)
>     ctx->Extensions.ARB_texture_env_crossbar = true;
>     ctx->Extensions.ARB_texture_env_dot3 = true;
>     ctx->Extensions.ARB_texture_float = true;
> +   ctx->Extensions.ARB_texture_mirror_clamp_to_edge = true;
>     ctx->Extensions.ARB_texture_non_power_of_two = true;
>     ctx->Extensions.ARB_texture_rg = true;
>     ctx->Extensions.ARB_texture_rgb10_a2ui = true;
>