[Mesa-dev] [PATCH] i965: Implement ARB_texture_mirror_clamp.

[Kenneth Graunke]

On 10/21/2013 12:58 AM, Rico Schüller wrote:
> I have one minor nitpick (see below). But either way, with the subject
> fixed (as mentioned by Matt), this is:
> Reviewed-by: Rico Schüller <kgbricola at web.de>
> 
> On 21.10.2013 07:24, Kenneth Graunke wrote:
>> This passes Piglit's texwrap tests (after applying Rico's patch to
>> make them use this extension).
>>
>> Cc: Rico Schüller <kgbricola at web.de>
>> Cc: Ian Romanick <idr at freedesktop.org>
>> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
>> ---
>>  src/mesa/drivers/dri/i965/brw_wm_sampler_state.c | 2 ++
>>  src/mesa/drivers/dri/i965/intel_extensions.c     | 1 +
>>  2 files changed, 3 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
>> index b716d61..db7ab60 100644
>> --- a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
>> +++ b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
>> @@ -71,6 +71,8 @@ translate_wrap_mode(GLenum wrap, bool using_nearest)
>>        return BRW_TEXCOORDMODE_CLAMP_BORDER;
>>     case GL_MIRRORED_REPEAT: 
>>        return BRW_TEXCOORDMODE_MIRROR;
>> +   case GL_MIRROR_CLAMP_TO_EDGE_EXT:
>> +      return BRW_TEXCOORDMODE_MIRROR_ONCE;
> I'd prefer GL_MIRROR_CLAMP_TO_EDGE instead of
> GL_MIRROR_CLAMP_TO_EDGE_EXT but as it is the same value it really
> shouldn't matter.

Me too.  My system GL headers didn't have "GL_MIRROR_CLAMP_TO_EDGE", so
I didn't realize it existed.  But it does!  Thanks!

--Ken