[Mesa-dev] [PATCH 5/8] i965/gs: Fix up gl_PointSize input swizzling for DUAL_INSTANCED gs.

[Eric Anholt]

Paul Berry <stereotype441 at gmail.com> writes:

> On 21 October 2013 18:34, Eric Anholt <eric at anholt.net> wrote:
>> Another option: How about instead of that assert in brw_eu_emit.c, we
>> just smash the vstride to be width * hstride?  We know the vstride
>> doesn't matter, because you're only using execsize components, so let's
>> just not bother our brw_eu.c callers with this little problem.
>>
>
> I'm not really a fan of this--it feels like it's perpetuating the "<8;8,1>
> instead of <4;4,1>" lie by introducing even more code in brw_eu_emit.c to
> fix things up when we use a bogus <8;8,1> region.  Also, if we do this,
> there's no convenient place to put the assert(force_writemask_all), which I
> think is really valuable.
>
> I would rather stick with the fixup at the top of
> generate_vec4_instruction() for now, and revisit the decision when we get
> rid of guess_execution_size().

This is totally fine with me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131022/39eac577/attachment.pgp>