[Mesa-dev] [PATCH 03/17] mesa: Use correct data for MAX_{VERTEX, GEOMETRY}_VARYING_COMPONENTS_ARB queries

Paul Berry stereotype441 at gmail.com
Wed Sep 11 13:23:45 PDT 2013


On 10 September 2013 12:10, Ian Romanick <idr at freedesktop.org> wrote:

> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Previously gl_constants::MaxVaryingComponents was used.  Now
> gl_constants::VertexProgram::MaxOutputs and
> gl_constants::GeometryProgram::MaxOutputs are used.
>
> This means that st_extensions.c had to be updated to set these fields
> instead of o MaxVaryingComponents.  It was previously the only place
> that set MaxVaryingComponents.
>

To clarify, does that mean that on non-state-tracker-based drivers, these
queries return uninitialized data?  I'm fine with that, since it's the case
both before and after this patch (and it looks like you fix it in patch 5),
but you might want to make a mention of it in the commit message.

Either way, the patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130911/2876f0ff/attachment.html>


More information about the mesa-dev mailing list