[Mesa-dev] [PATCH 03/17] mesa: Use correct data for MAX_{VERTEX, GEOMETRY}_VARYING_COMPONENTS_ARB queries

[Ian Romanick]

On 09/11/2013 03:23 PM, Paul Berry wrote:
> On 10 September 2013 12:10, Ian Romanick <idr at freedesktop.org
> <mailto:idr at freedesktop.org>> wrote:
> 
>     From: Ian Romanick <ian.d.romanick at intel.com
>     <mailto:ian.d.romanick at intel.com>>
> 
>     Previously gl_constants::MaxVaryingComponents was used.  Now
>     gl_constants::VertexProgram::MaxOutputs and
>     gl_constants::GeometryProgram::MaxOutputs are used.
> 
>     This means that st_extensions.c had to be updated to set these fields
>     instead of o MaxVaryingComponents.  It was previously the only place
>     that set MaxVaryingComponents.
> 
> 
> To clarify, does that mean that on non-state-tracker-based drivers,
> these queries return uninitialized data?  I'm fine with that, since it's
> the case both before and after this patch (and it looks like you fix it
> in patch 5), but you might want to make a mention of it in the commit
> message.

I believe that the structure is allocated by calloc, so the value should
be initialized to zero before and after my change.  Right now nobody
enables GL_ARB_geometry_shader4, so it's pretty much dead code anyway.

I will add all that information to the commit message.

> Either way, the patch is:
> 
> Reviewed-by: Paul Berry <stereotype441 at gmail.com
> <mailto:stereotype441 at gmail.com>>